Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unload/load in ModuleGeneratorLua.swap_module, since 'swap' is not supported by Lmod #3685

Merged
merged 2 commits into from May 20, 2021
Merged

use unload/load in ModuleGeneratorLua.swap_module, since 'swap' is not supported by Lmod #3685

merged 2 commits into from May 20, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented May 18, 2021 •
edited

fixes #3626

@boegel boegel added bug fix cray Issues and PRs related to integration with Cray PE labels May 18, 2021
@boegel boegel added this to the next release (4.4.0) milestone May 18, 2021
@boegel boegel changed the title use unload/load in ModuleGeneratorLua.swap_module, since 'swap' is not supported by Lmod (fixes #3626) use unload/load in ModuleGeneratorLua.swap_module, since 'swap' is not supported by Lmod May 18, 2021
@boegel boegel mentioned this pull request May 18, 2021
Closed
migueldiascosta
migueldiascosta approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit b03612a into easybuilders:develop May 20, 2021
@boegel boegel deleted the fix_swap_lua branch May 20, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
bug fix cray Issues and PRs related to integration with Cray PE
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Error creating Cray toolchain modulefiles with Lua syntax
2 participants
@boegel @migueldiascosta