Improve error finding #4001
Closed
Improve error finding #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| index += 1 | ||
|
|
||
|
|
||
| def parse(self, stream, context=6, jobs=None): |
| warning_exceptions = compile(_warning_exceptions) | ||
| file_line_matches = compile(_file_line_matches) | ||
|
|
||
| matcher, args = _match, [] |
There was a problem hiding this comment.
local variable 'args' is assigned to but never used
| error_exceptions = compile(_error_exceptions) | ||
| warning_matches = compile(_warning_matches) | ||
| warning_exceptions = compile(_warning_exceptions) | ||
| file_line_matches = compile(_file_line_matches) |
|
|
||
| error_matches = compile(_error_matches) | ||
| error_exceptions = compile(_error_exceptions) | ||
| warning_matches = compile(_warning_matches) |
| return [re.compile(regex) for regex in regex_array] | ||
|
|
||
| error_matches = compile(_error_matches) | ||
| error_exceptions = compile(_error_exceptions) |
| def compile(regex_array): | ||
| return [re.compile(regex) for regex in regex_array] | ||
|
|
||
| error_matches = compile(_error_matches) |
|
Closing this, as we'll look to implement some method to cover this as part of the EB 5.0 work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)This is a proof of concept. This is based off the discussion from EUM on this and I've implemented this in a way that allows others to test the messages it highlights.
This:
ctest_log_parser.pyfrom spack and puts it in a newexternaldirectorystdouterrfor each stage and: