Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex for extracting glibc version from output of 'ldd --version' in Gentoo Linux #4290

Merged
merged 2 commits into from Jul 4, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Jun 30, 2023

Without this change, we get UNKNOWN in a Gentoo Linux environment:

$ eb --show-system-info | grep glibc
  -> glibc version: UNKNOWN

That causes trouble with Qt5 for example, because get_glibc_version is used in the sanity check, which leads to:

  File "/cvmfs/pilot.eessi-hpc.org/versions/2023.06/software/linux/x86_64/generic/software/EasyBuild/4.7.2/lib/python3.11/site-packages/easybuild/easyblocks/q/qt.py", line 203, in sanity_check_step
    if LooseVersion(glibc_version) <= LooseVersion("2.16"):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64/usr/lib/python3.11/site-packages/setuptools/_distutils/version.py", line 78, in __le__
    c = self._cmp(other)
        ^^^^^^^^^^^^^^^^
  File "/cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64/usr/lib/python3.11/site-packages/setuptools/_distutils/version.py", line 351, in _cmp
    if self.version < other.version:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '<' not supported between instances of 'str' and 'int'

(cfr. EESSI/software-layer#284)

With this change, the glibc version is detected correctly also in Gentoo:

[EESSI pilot 2023.06] $ ldd --version
ldd (Gentoo 2.37-r3 (patchset 5)) 2.37
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

[EESSI pilot 2023.06] $ eb --show-system-info | grep glibc
  -> glibc version: 2.37

@boegel boegel added bug fix EESSI Related to EESSI project labels Jun 30, 2023
@boegel boegel added this to the next release (4.7.3?) milestone Jun 30, 2023
@boegel boegel requested a review from ocaisa June 30, 2023 08:59
@ocaisa ocaisa enabled auto-merge July 4, 2023 15:43
@ocaisa ocaisa merged commit 6a8b109 into easybuilders:develop Jul 4, 2023
35 checks passed
@boegel boegel deleted the relax_glibc_version_pattern branch July 4, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants