Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable trace output for commands run in get_source_tarball_from_git #4310

Merged
merged 2 commits into from Aug 7, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 6, 2023

This fixes test_get_source_tarball_from_git when the test is not skipped sicne a GitHub token is available, which is broken because of the additional trace output (caused by enabling --trace by default in #4250):

FAIL: test_get_source_tarball_from_git (test.framework.filetools.FileToolsTest)
Test get_source_tarball_from_git function.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/runner/405fb0cc2a0118c1b3f4332611c244409b9d3fa5/lib/python3.6/site-packages/test/framework/filetools.py", line 2782, in test_get_source_tarball_from_git
    run_check()
  File "/tmp/runner/405fb0cc2a0118c1b3f4332611c244409b9d3fa5/lib/python3.6/site-packages/test/framework/filetools.py", line 2765, in run_check
    self.assertTrue(regex.search(stdout), "Pattern '%s' found in: %s" % (regex.pattern, stdout))
AssertionError: None is not true : Pattern '  running command "git clone --depth 1 --branch tag_for_tests git@github.com:easybuilders/testrepository.git"
  \(in .*/tmp.*\)
  running command "tar cfvz .*/target/test.tar.gz --exclude .git testrepository"
  \(in .*/tmp.*\)' found in:   >> running command:
	[started at: 2023-08-06 16:53:17]
	[working dir: /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/eb-p08iwl5l/eb-yovari1d/tmpp_ixh545]
	[output logged in /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/eb-p08iwl5l/eb-yovari1d/easybuild-run_cmd-vtki1hp8.log]
	git clone --depth 1 --branch tag_for_tests git@github.com:easybuilders/testrepository.git
  running command "git clone --depth 1 --branch tag_for_tests git@github.com:easybuilders/testrepository.git"
  (in /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/eb-p08iwl5l/eb-yovari1d/tmpp_ixh545)
  >> running command:
	[started at: 2023-08-06 16:53:17]
	[working dir: /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/eb-p08iwl5l/eb-yovari1d/tmpp_ixh545]
	[output logged in /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/eb-p08iwl5l/eb-yovari1d/easybuild-run_cmd-l1po41__.log]
	tar cfvz /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/target/test.tar.gz --exclude .git testrepository
  running command "tar cfvz /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/target/test.tar.gz --exclude .git testrepository"
  (in /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/eb-p08iwl5l/eb-yovari1d/tmpp_ixh545)
directory /tmp/eb-edjcffb7/eb-4r4ias8b/eb-sq9lqq1o/eb-p08iwl5l/eb-yovari1d/tmpp_ixh545 removed

@boegel boegel added this to the 5.0 milestone Aug 6, 2023
@boegel boegel changed the title disable trace output for commands run in get_source_tarball_from_git disable trace output for commands run in get_source_tarball_from_git Aug 6, 2023
@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Aug 6, 2023
@boegel boegel requested a review from branfosj August 6, 2023 18:36
@branfosj branfosj merged commit 9e78ca3 into easybuilders:5.0.x Aug 7, 2023
32 checks passed
@boegel boegel deleted the fix_get_source_tarball_from_git branch August 7, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants