Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement fail_on_error/in_dry_run/output_file options + enable caching for run function, and switch from run_cmd to run function in systemtools #4314

Merged
merged 3 commits into from Aug 9, 2023
Merged

implement fail_on_error/in_dry_run/output_file options + enable caching for run function, and switch from run_cmd to run function in systemtools #4314

merged 3 commits into from Aug 9, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 7, 2023

No description provided.

@boegel boegel added this to the 5.0 milestone Aug 7, 2023
ocaisa
ocaisa reviewed Aug 8, 2023
View reviewed changes
easybuild/tools/run.py Outdated Show resolved Hide resolved
ocaisa
ocaisa requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one issue

easybuild/tools/run.py Show resolved Hide resolved
@ocaisa ocaisa merged commit cf5177f into easybuilders:5.0.x Aug 9, 2023
32 checks passed
@boegel boegel deleted the run_systemtools branch August 11, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0 enhancement
Projects
EasyBuild v5.0
Status: Done
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @ocaisa