Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger run_shell_cmd hook in run function #4334

Merged
merged 7 commits into from Aug 24, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 23, 2023

This includes changes required for the 5.0.x branch to fix the tests after it was synced with develop which includes changes from #4323 .

I had to move the load_source function from tools.filetools to tools.hooks, to break an import loop (was got introduced since tools.run now imports from tools.hooks)

@boegel boegel changed the title trigger run_cmd_shell hook in run function trigger run_shell_cmd hook in run function Aug 24, 2023
@easybuilders easybuilders deleted a comment from boegelbot Aug 24, 2023
@boegel boegel added this to the 5.0 milestone Aug 24, 2023
test/framework/toy_build.py Outdated Show resolved Hide resolved
…kedirs in py2vs3/py3.py is just os.makedirs, not a wrapper function like it was in py2vs3/py2.py
@branfosj branfosj merged commit e2b3d4f into easybuilders:5.0.x Aug 24, 2023
32 checks passed
@boegel boegel deleted the run_run_shell_cmd_hook branch August 24, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants