Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error reporting for failing shell commands (and EasyBuild crashes) #4351

Merged
merged 12 commits into from
Oct 23, 2023
Merged

improve error reporting for failing shell commands (and EasyBuild crashes) #4351

merged 12 commits into from
Oct 23, 2023

Commits on Oct 7, 2023

  1. let run_shell_cmd produce error report when shell command failed

    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    46c686f View commit details
    Browse the repository at this point in the history

  2. rename RunResult to RunShellCmdResult

    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    07c85f2 View commit details
    Browse the repository at this point in the history

  3. separate EasyBuild crashes (unexpected exception being raised) from E… 

    …asyBuildError being raised, add crash hook, improve general error reporting
    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    2119ff4 View commit details
    Browse the repository at this point in the history

  4. separate raising of RunShellCmdError from printing info on failed she… 

    …ll command, log command output before log message that mentions success of failure for command
    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    df3b72c View commit details
    Browse the repository at this point in the history

  5. catch RunShellCmdError in EasyBlock.run_all_steps to do more meaningf… 

    …ul error reporting incl. step name and easyconfig filename
    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    0b7f351 View commit details
    Browse the repository at this point in the history

  6. make hooks tests aware of crash hook

    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    ce34aae View commit details
    Browse the repository at this point in the history

  7. add test that cover EasyBuild crashing

    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9d716d9 View commit details
    Browse the repository at this point in the history

  8. fix unused imports + trivial code style issues in main.py and tools/r… 

    …un.py
    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    7d2d537 View commit details
    Browse the repository at this point in the history

  9. fix broken tests due to changes in error handling

    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    eb768a1 View commit details
    Browse the repository at this point in the history

  10. fix faulty imports in toy_build test module

    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    219be7c View commit details
    Browse the repository at this point in the history

  11. don't use f-strings without a placeholder

    @boegel
    boegel committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9ab36ed View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. collapse print_run_shell_cmd_error into RunShellCmdError as print method

    @boegel
    boegel committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ece71c2 View commit details
    Browse the repository at this point in the history