Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix LIBBLAS_MT for FlexiBLAS, ensure -lpthread is included #4379

Merged
merged 13 commits into from Dec 8, 2023
Merged

fix LIBBLAS_MT for FlexiBLAS, ensure -lpthread is included #4379

merged 13 commits into from Dec 8, 2023

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Nov 10, 2023 •
edited

(created using eb --new-pr)

cfr. similar fix for openblas #3584

@smoors smoors added the bug fix label Nov 10, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Nov 22, 2023
@boegel boegel changed the title fix LIBBLAS_MT for flexiblas, ensure -lpthread is included fix LIBBLAS_MT for FlexiBLAS, ensure -lpthread is included Nov 22, 2023
@boegel boegel changed the title fix LIBBLAS_MT for FlexiBLAS, ensure -lpthread is included fix LIBBLAS_MT for FlexiBLAS, ensure -lpthread is included Nov 22, 2023
@boegel
Copy link
Member

boegel commented Nov 22, 2023

@smoors Can we cover this in the tests (like we did in #3584)?

@smoors smoors mentioned this pull request Nov 27, 2023
Merged
@smoors
Copy link
Contributor Author

smoors commented Dec 7, 2023 •
edited

the end-to-end test fails with

== building and installing M4/1.4.19...
installation prefix: /home/easybuild/.local/easybuild/software/M4/1.4.19
== fetching files...
== ... (took 1 secs)
== FAILED: Installation ended unsuccessfully (build directory: /home/easybuild/.local/easybuild/build/M4/1.4.19/system-system): build failed (first 300 chars): SSL issues with urllib2. If you are using RHEL/CentOS 6.x please install the python-requests and pyOpenSSL RPM packages and try again. (took 1 secs)

re-running with debug on...
edit: apparently it was a fluke, all is fine now

boegel
boegel approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 850b7fd into easybuilders:develop Dec 8, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smoors @boegel