Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print error message in main_with_hooks function when EasyBuildError was raised #4380

Merged
merged 1 commit into from Nov 13, 2023
Merged

print error message in main_with_hooks function when EasyBuildError was raised #4380

merged 1 commit into from Nov 13, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 13, 2023

also deprecates exitCode in print_error, replaced with exit_code (very small impact, since exitCode is not actually used anywhere in framework or easyblocks)

@boegel boegel added bug fix EasyBuild-5.0 EasyBuild 5.0 labels Nov 13, 2023
@boegel boegel added this to the 5.0 milestone Nov 13, 2023
@boegel boegel changed the title print error message when EasyBuildError was raised in main_with_hooks function print error message when EasyBuildError was raised in main_with_hooks function Nov 13, 2023
@boegel boegel changed the title print error message when EasyBuildError was raised in main_with_hooks function print error message in main_with_hooks function when EasyBuildError was raised Nov 13, 2023
smoors
smoors approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors merged commit 95e752c into easybuilders:5.0.x Nov 13, 2023
35 checks passed
@boegel boegel deleted the fix_error_reporting branch November 13, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoors smoors smoors approved these changes

Assignees
No one assigned
Labels
bug fix EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: Done
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @smoors