add check_group support for module files in Tcl syntax
#4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
check_group support for Tcl modulefile
boegel
requested changes
Jan 3, 2024
boegel
changed the title
check_group support for Tcl modulefilecheck_group support for module files in Tcl syntax
|
@xdelaruelle Can you look into fixing the merge conflict here? |
Move into ModuleTool classes the definition of required version to insert check group code in Lua modulefile. Gather this way all kind of required version information in ModuleTool classes.
"module-info usergroups" modulefile command has been introduced on Environment Modules version 4.6.0. This commit adds support for check_group in Tcl modulefile when required module tool and version is used.
xdelaruelle
force-pushed
the
check_group
branch
from
58c5afa
to
236c68a
Compare
|
@boegel Merge conflict has been solved. Everything seem fine on my side. Please let me know if something else should be changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"module-info usergroups" modulefile command has been introduced on Environment Modules version 4.6.0. This commit adds support for check_group in Tcl modulefile when required module tool and version is used.