Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate run_cmd and run_cmd_qa & co, move them to easybuild._deprecated module #4433

Merged
merged 13 commits into from Apr 17, 2024

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 5, 2024

All code in easybuild/_deprecated.py was cut from easybuild/tools/run.py without changes, with one small exception: the run_cmd_cache decorator was changed to only consider inp, not stdin (since the latter is specific to run_shell_cmd).

WIP because more work is needed here once the implementation of run_shell_cmd is complete (incl. support for asynchronous and qa_patterns + qa_wait_patterns):

  • also deprecate other functions in easybuild._deprecated, like run_cmd_qa, etc.;
  • use self.allow_deprecated_behaviour() in tests where needed, or catch deprecation warning to ignore it;

@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Jan 5, 2024
@boegel boegel added this to the 5.0 milestone Jan 5, 2024
@boegel boegel changed the title deprcate run_cmd and run_cmd_qa & co, move them to easybuild._deprecated module (WIP) deprecate run_cmd and run_cmd_qa & co, move them to easybuild._deprecated module (WIP) Jan 15, 2024
@boegel boegel changed the title deprecate run_cmd and run_cmd_qa & co, move them to easybuild._deprecated module (WIP) deprecate run_cmd and run_cmd_qa & co, move them to easybuild._deprecated module Apr 9, 2024
@easybuilders easybuilders deleted a comment from boegelbot Apr 9, 2024
@boegel boegel marked this pull request as ready for review April 16, 2024 07:31
@branfosj branfosj merged commit fb286aa into easybuilders:5.0.x Apr 17, 2024
35 checks passed
@boegel boegel deleted the run_cmd_deprecate branch April 17, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants