Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement support for running interactive commands with run_shell_cmd #4453

Merged
merged 18 commits into from
Apr 6, 2024
Merged

implement support for running interactive commands with run_shell_cmd #4453

merged 18 commits into from
Apr 6, 2024

Commits on Feb 22, 2024

  1. implement basic support for qa_patterns in run_shell_cmd

    @boegel
    boegel committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4ff3663 View commit details
    Browse the repository at this point in the history

  2. add support for qa_timeout in run_shell_cmd + check type of qa_patter… 

    …ns value
    @boegel
    boegel committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1cce873 View commit details
    Browse the repository at this point in the history

  3. fix trivial code style issues

    @boegel
    boegel committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    651da97 View commit details
    Browse the repository at this point in the history

  4. simplify qa_timeout code in run_shell_cmd by using for-else statement

    @boegel
    boegel committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    f01ef65 View commit details
    Browse the repository at this point in the history

  5. fix default value for qa_timeout (we're counting seconds, not millise… 

    …conds)
    @boegel
    boegel committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5899ce2 View commit details
    Browse the repository at this point in the history

  6. fix trace message for interactive commands run with run_shell_cmd

    @boegel
    boegel committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    cfb7f3a View commit details
    Browse the repository at this point in the history

  7. make sure that *all* stdout/stderr output is read when streaming outp… 

    …ut or running interactive commands
    @boegel
    boegel committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4b63b91 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Merge branch '5.0.x' into run_shell_cmd_qa

    @boegel
    boegel committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    23fa25c View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. add support to run_shell_cmd for providing list of answers in qa_patt… 

    …erns + fix output for hooks triggered for interactive shell commands run with run_shell_cmd
    @boegel
    boegel committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5783910 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. implement qa_wait_patterns option in run_shell_cmd

    @boegel
    boegel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    717f555 View commit details
    Browse the repository at this point in the history

  2. fix excessively long line in test_run_shell_cmd_qa_answers

    @boegel
    boegel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f020bf9 View commit details
    Browse the repository at this point in the history

  3. add support to run_shell_cmd for completing answer via pattern extrac… 

    …ted from question
    @boegel
    boegel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    7d5c7ce View commit details
    Browse the repository at this point in the history

  4. improve logging in Q&A part of run_shell_cmd

    @boegel
    boegel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    7145ca9 View commit details
    Browse the repository at this point in the history

  5. only show last 1000 characters in debug log message when answering qu… 

    …estions for interactive commands in run_shell_cmd function
    @boegel
    boegel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f3e5a65 View commit details
    Browse the repository at this point in the history

  6. only check for questions to be answered every 0.1s

    @boegel
    boegel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ca21ff6 View commit details
    Browse the repository at this point in the history

  7. flesh out code to try and answer question raised by interactive shell… 

    … command from run_shell_cmd into private helper function _answer_question
    @boegel
    boegel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2abb706 View commit details
    Browse the repository at this point in the history

  8. don't reset time_no_match in _answer_question, do it in run_shell_cmd

    @boegel
    boegel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    23727d6 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. tackle Simon's suggestions for run_shell_cmd

    @boegel
    boegel committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    204f328 View commit details
    Browse the repository at this point in the history