Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update easyblocks for toy extensions to make sure that asynchronous installation command is run in correct working directory #4471

Merged
merged 2 commits into from
Mar 2, 2024
Merged

update easyblocks for toy extensions to make sure that asynchronous installation command is run in correct working directory #4471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff4ff49
update easyblocks for toy extensions to make sure that asynchronous i…
boegel Mar 1, 2024
4419025
Merge branch '5.0.x' of github.com:easybuilders/easybuild-framework i…
boegel Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/framework/sandbox/easybuild/easyblocks/generic/toy_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def run_async(self, thread_pool):
cmd = f"echo 'no sources for {self.name}'"

return thread_pool.submit(run_shell_cmd, cmd, asynchronous=True, env=os.environ.copy(),
fail_on_error=False, task_id=task_id)
fail_on_error=False, task_id=task_id, work_dir=os.getcwd())

def postrun(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion test/framework/sandbox/easybuild/easyblocks/t/toy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def run_async(self, thread_pool):
cmd = compose_toy_build_cmd(self.cfg, self.name, self.cfg['prebuildopts'], self.cfg['buildopts'])
task_id = f'ext_{self.name}_{self.version}'
return thread_pool.submit(run_shell_cmd, cmd, asynchronous=True, env=os.environ.copy(),
fail_on_error=False, task_id=task_id)
fail_on_error=False, task_id=task_id, work_dir=os.getcwd())

def postrun(self):
"""
Expand Down