fix easyconfig parameter deprecation #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have support for deprecating easyconfig parameters by adding them to the
DEPRECATED_PARAMETERSdict ineasybuild/framework/easyconfigs/parser.py.However, there is currently a bug -- both
triage_easyconfig_params()andset_keys()ineasybuild/framework/easyconfig/easyconfig.pyend up ignoring deprecated parameters, should they appear in an easyconfig. Instead, they're treated as a local variables/unkown easyconfig parameter.this isn't actually specific to easybuild 5 (exists in 4.x at least, maybe older versions too), but since it hasn't come up before I've just targetted 5.0.x