Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer $EBPYTHONPREFIXES over $PYTHONPATH #4496

Draft
wants to merge 17 commits into
base: 5.0.x
Choose a base branch
from
Draft

Prefer $EBPYTHONPREFIXES over $PYTHONPATH #4496

wants to merge 17 commits into from

Commits on Apr 11, 2024

  1. Make new safe module abstraction for update_paths

    @Micket
    Micket authored and C3SE "c3-builder" bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0ec2df5 View commit details
    Browse the repository at this point in the history

  2. Replace PYTHONPATHs with EBPYTHONPREFIX when possible 

    Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
    @Micket @Flamefire
    2 people authored and C3SE "c3-builder" bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    74a3cb3 View commit details
    Browse the repository at this point in the history

  3. Add option prefer-ebpythonprefix-over-pythonpath

    @Micket
    Micket authored and C3SE "c3-builder" bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    03e304e View commit details
    Browse the repository at this point in the history

  4. Add warning for duplicated PYTHONPATH's that should not occur

    @Micket
    Micket authored and C3SE "c3-builder" bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b07ea3f View commit details
    Browse the repository at this point in the history

  5. Add tests for PYTHONPATH to EBPYTHONPREFIX rewrite

    @Micket
    Micket authored and C3SE "c3-builder" bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8c66e1a View commit details
    Browse the repository at this point in the history

  6. Move check for faulty PYTHONPATHs to always run it 

    It's even more important for those who don't use EBPYTHONPREFIX
to ensure it doesn't add multiple mixed PYTHONPATH's
    @Micket
    Micket authored and C3SE "c3-builder" bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ccd3d7e View commit details
    Browse the repository at this point in the history

  7. Move conversion of paths as str to lists earlier removing duplicated … 

    …code
    @Micket
    Micket authored and C3SE "c3-builder" bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f76f320 View commit details
    Browse the repository at this point in the history

  8. Fix name EBPYTHONPREFIX to EBPYTHONPREFIXES which is used in sitecust… 

    …omize.py
    @Micket
    Micket authored and C3SE "c3-builder" bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8b5389f View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Move _filter_paths check to _update_paths 

    This will ensure duplicate paths are filtered even when EBPYTHONPREFIXES
rewrite is in place.
    @Micket
    Micket committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    cb6adb0 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Simplify logic for _filter_paths

    @Micket
    Micket committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    4a11f2f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Rename flag to replace_pythonpath

    @Micket
    Micket committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    c471e03 View commit details
    Browse the repository at this point in the history

  2. Add assertion for input argument to _filter_paths.

    @Micket
    Micket committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    2676e4e View commit details
    Browse the repository at this point in the history

  3. Improve typing hints for list of str 

    Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
    @Micket @Flamefire
    Micket and Flamefire committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    f4fbe76 View commit details
    Browse the repository at this point in the history

  4. Also use List from typing 

    Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
    @Micket @Flamefire
    Micket and Flamefire committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    92f0e62 View commit details
    Browse the repository at this point in the history

  5. Improve typing hints for list of str 

    Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
    @Micket @Flamefire
    Micket and Flamefire committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e91186e View commit details
    Browse the repository at this point in the history

  6. Improve typing hints for list of str 

    Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
    @Micket @Flamefire
    Micket and Flamefire committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    236c67f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Update easybuild/tools/module_generator.py 

    Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
    @Micket @Flamefire
    Micket and Flamefire committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ca304fb View commit details
    Browse the repository at this point in the history