Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for easyconfig parameter module_only #4537

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

smoors
Copy link
Contributor

@smoors smoors commented May 20, 2024

the motivation is to support installing only the module for certain deps of a software when installing with eb --robot
the module_only parameter can then be set in a hook depending on a certain condition
use case: installing only the module for CUDA software on non-GPU nodes (e.g. the login nodes), thus making the CUDA modules visible (but not actually usable)

@boegel this helps getting the VSC-bot working in hydra by replacing the 'dummy modules' feature in our submit_build script with a hook

@boegel boegel changed the title add support for parameter module_only add support for easyconfig parameter module_only May 21, 2024
@boegel boegel added this to the 4.x milestone May 22, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in easybuild/* look OK to me, but we need a test for this...

@smoors
Copy link
Contributor Author

smoors commented May 23, 2024

changes in easybuild/* look OK to me, but we need a test for this...

test added in 64cde9e

# check use of module_only parameter
test_ec_txt += "\nmodule_only = True\n"
write_file(test_ec, test_ec_txt)
self.eb_main(args, do_build=True, raise_error=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors You should tweak args here too, so it doesn't include --skip anymore (or --force, I guess), and also check that no software was installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 430189c

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel modified the milestones: 4.x, release after 4.9.1 Jun 5, 2024
@boegel boegel merged commit f2a99de into easybuilders:develop Jun 5, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants