Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't try to determine repo version when file that contains version doesn't exist #4553

Merged
merged 1 commit into from
Jun 7, 2024
Merged

don't try to determine repo version when file that contains version doesn't exist #4553

merged 1 commit into from
Jun 7, 2024

Conversation

boegel
Copy link
Member

@boegel boegel commented Jun 7, 2024

fix for a couple of broken GitHub tests in framework test suite, and for using --from-pr on a closed PR:

$ eb --from-pr 8006 -D
== Temporary log file in case of crash /tmp/eb-64svltcd/easybuild-v6yqv27h.log
WARNING: Using easyconfigs from closed PR #8006

ERROR: Couldn't determine version of PR from /tmp/eb-64svltcd/files_pr8006/setup.py

@boegel boegel added the bug fix label Jun 7, 2024
@boegel boegel added this to the 4.9.2 milestone Jun 7, 2024
@boegel boegel requested a review from branfosj June 7, 2024 19:43
bartoldeman
bartoldeman approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bartoldeman bartoldeman merged commit f9134b1 into easybuilders:develop Jun 7, 2024
37 checks passed
@boegel boegel deleted the fix_det_version_closed_pr branch June 7, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

@branfosj branfosj Awaiting requested review from branfosj

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.9.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @bartoldeman