Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinstate optional '(default)' suffix for 'module avail' #724

Merged
merged 3 commits into from Oct 16, 2013

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 16, 2013

reinstate optional (default) suffix for module avail, since it's not stripped off with --terse in environment modules (it only is by lmod)

unit tests are enhanced to catch this problem should it occur again

@boegel
Copy link
Member Author

boegel commented Oct 16, 2013

The typical way of this bug being hit is when a module that is required as dependency is not seen by EasyBuild even though it is available, because it is marked as (default):

$ module av ictce
------------------------------------ /path/to/modules/all ------------------------------------
ictce/4.0.10      ictce/4.0.6      ictce/4.1.13(default)      ictce/5.1.1      ictce/5.3.0

$ eb gzip-1.5-ictce-4.1.13.eb
...
ERROR: EasyBuild crashed with an error (at easybuild/main.py:556 in resolve_dependencies):
Dependencies not met. Cannot resolve ["ictce/4.1.13 for {'dummy': True, 'toolchain':
{'version': 'dummy', 'name': 'dummy'}, 'name': 'ictce', 'versionsuffix': '',
'version': '4.1.13', 'parsed': True}"]

# line ending with : is ignored (the modulepath in --terse)
# FIXME: --terse ignores defaultness
'available': re.compile(r"^\s*(?P<mod_name>[^\(\s:]+)\s*[^:\S]*$")
# lines ending are ':' is ignored (the modulepath in --terse)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean here?

@stdweird
Copy link
Contributor

looks fine, please regtest

@boegel
Copy link
Member Author

boegel commented Oct 16, 2013

@stdweird: Thanks for the review, I'll merge this into develop and also in v1.8.x, and look into a full regtest for a v1.8.2 release of EasyBuild...

boegel added a commit that referenced this pull request Oct 16, 2013
reinstate optional '(default)' suffix for 'module avail'
@boegel boegel merged commit eb4748e into easybuilders:develop Oct 16, 2013
@boegel boegel deleted the fix_module_avail branch October 16, 2013 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants