Typecheck format2 #827
Typecheck format2 #827
Conversation
|
@boegel i'm also tackling the suffix in version operator issue. i need matching separators. |
|
@boegel this does not build (i need a vsc-base bump for that) |
|
@boegel has Dependency class, sits on top of develop now |
| class Patches(ListOfStrings): | ||
| """Handle patches as list of Patch | ||
| """ | ||
|
|
|
@boegel small refactor and extra dealings with robot path |
ListOfStringsAndDictOfStrings
option (and make the argument printable). options.robot shouldn't be modified anymore (the commandline must be protected)
|
@boegel done |
| # # | ||
|
|
||
| """ | ||
| This module implements easyconfig specific formats and their converts |
|
|
||
| res = {} | ||
| ml_usage = [-1] | ||
| for idx, pairs in enumerate(self._split_string(txt, sep=self.separator_dict)): |
There was a problem hiding this comment.
why pairs? shouldn't that be entry or item or something like that? pairs doesn't make sense to me, but maybe I'm missing something
|
@boegel, i addressed most of the remarks. the rest i consider personal preferences. in particular wrt the tests, i only favour hardcoding if no class constants are used for the separators. |
| """ | ||
|
|
||
| res = {} | ||
| ml_usage = [-1] |
There was a problem hiding this comment.
add a comment here to explain why the list is initiated with -1? it looks weird
There was a problem hiding this comment.
the comment is below, but i'll try to come up with better implementation
|
@stdweird: One more missing license header in a test module. We'll just need another PR to actually use |
|
@boegel added the missing lic header |
|
@stdweird: I'll merge this in, and create a new PR to actually start using |
(This sits on top of the build_stats PR)