Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install EasyBuild as a module in base image + clean up GCC 9.3.0 image #8

Merged
merged 5 commits into from
May 29, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented May 28, 2020

No description provided.

@@ -4,11 +4,13 @@ ARG EB_VER=4.2.1
LABEL easybuild_version=${EB_VER}
# install required packages (EPEL is required for Lmod)
RUN yum install -y epel-release \
&& yum install -y bzip2 file gcc-c++ git Lmod make openssl-devel patch python3-pip unzip vim which
&& yum install -y bzip2 file gcc-c++ git Lmod make openssl openssl-devel patch python3-pip unzip vim which rdma-core-devel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we install rdma-core-devel here? Who is to say someone wants to run RDMA stuff

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having rdma-core-devel installed affects how OpenMPI is configured (--with-verbs or --without-verbs).

I'm happy to remove it, it's probably overkill here, but I don't think it hurts to have it installed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wonder if we need to install this in the base - but ok... premature optimization I'd say

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I don't think it hurts much, except for size of the container a little bit?

Stripping it out is not a huge deal for the tutorial, and if it's there you can add rdma-core-devel in another image on top of this one, and rebuild OpenMPI (and everything that depends on it...), if you really want IB support, but that's a hassle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it for now... and put a pin in it for a later discussion

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue on it in this repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10

containers/Dockerfile.base-centos7 Outdated Show resolved Hide resolved
containers/Dockerfile.base-centos7 Outdated Show resolved Hide resolved
&& ml --version \
&& which -a eb \
&& eb --version \
&& eb --show-system-info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

&& eb --show-system-info
# remove globally installed EasyBuild, we can use the module going forward
USER root
RUN pip3 uninstall -y easybuild
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potential optimization #11

@boegel boegel merged commit 5f67a29 into master May 29, 2020
@boegel boegel deleted the better_base branch May 29, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants