Dashicons is a large dependency for one icon #5331
Comments
|
I have a big PR on front-end stuff which includes this. Juat
…On Jan 3, 2017 12:06 AM, "Josh Pollock" ***@***.***> wrote:
As far as I can tell dashicons are only being enqueued to show the padlock
on the checkout form. That is a 28.6 kB file for one icon. I think it would
make sense to use an inline svg, or maybe add a cut down version of
dashicons to main stylesheet.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5331>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvG_9QHnXAuAOTEi3N5-g_b74ApLPpLks5rOXTegaJpZM4LZOwc>
.
|
|
I have a big PR on front-end stuff which includes this. Juat
On Jan 3, 2017 12:06 AM, "Josh Pollock" <notifications@github.com> wrote:
As far as I can tell dashicons are only being enqueued to show the padlock
on the checkout form. That is a 28.6 kB file for one icon. I think it would
make sense to use an inline svg, or maybe add a cut down version of
dashicons to main stylesheet.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5331>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvG_9QHnXAuAOTEi3N5-g_b74ApLPpLks5rOXTegaJpZM4LZOwc>
.
|
|
Ups... Just need time to finish it.
…On Jan 3, 2017 12:06 AM, "Josh Pollock" ***@***.***> wrote:
As far as I can tell dashicons are only being enqueued to show the padlock
on the checkout form. That is a 28.6 kB file for one icon. I think it would
make sense to use an inline svg, or maybe add a cut down version of
dashicons to main stylesheet.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5331>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvG_9QHnXAuAOTEi3N5-g_b74ApLPpLks5rOXTegaJpZM4LZOwc>
.
|
|
@samikeijonen That's good to hear. I de enqueued it on our site. I used a PNG icon instead. Question: Should I open issues in other plugins that are doing this (I think it was EDD Recurring and AffiliateWP that I saw, but will have to check) or is that part of your plan? |
|
Here is the PR: #5177.
I'd say yes if they are using Dashicon in different place than in EDD Core. Naturally AffiliateWP is a different story:) |
|
Closing as this was fixed in #5166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As far as I can tell dashicons are only being enqueued to show the padlock on the checkout form. That is a 28.6 kB file for one icon. I think it would make sense to use an inline svg, or maybe add a cut down version of dashicons to main stylesheet.
The text was updated successfully, but these errors were encountered: