Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The EDD CSS files were too aggressively loaded #2098

Closed
wants to merge 2 commits into from
Closed

The EDD CSS files were too aggressively loaded #2098

wants to merge 2 commits into from

Conversation

zackkatz
Copy link
Contributor

@zackkatz zackkatz commented Mar 5, 2014

The jQuery UI scripts in particular were being used throughout the admin and altering non-EDD page layouts.

The jQuery UI scripts in particular were being used throughout the admin and altering non-EDD page layouts.
@chriscct7
Copy link
Member

Hi there,
Thanks for the pull request 👍 . This indeed was a topic we wanted to revisit for 2.0.

You need to add a filter so extensions can also hook in. Alot of EDD extensions are built using those jQuery UI css files, and have pages that won't qualify as under the downloads post type or start using edd for the page names.

Also, this patch needs to be submitted to the release/2.0 or release/2.1, since we'll need to give some time for the affected extension authors to update their extensions to use the aforementioned filter.

I'm personally thinking 2.1 at the moment, but we'll discuss this later today and get back to you.

In the meantime, if you need to dequeue the UI files, you can use this: http://wordpress.org/support/topic/edd-is-loading-jquery-ui-css-on-non-edd-admin-pages?replies=4

Extensions can use `add_filter('edd_force_load_scripts',
'__return_true');` to have EDD scripts to load on their page.
@zackkatz
Copy link
Contributor Author

zackkatz commented Mar 5, 2014

Hi Chris,
I've added the edd_force_load_scripts filter to override the page check. I wasn't sure what the name of the filter should be...

Let me know which version I should submit to. Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 31895b3 on zackkatz:patch-1 into e57e274 on easydigitaldownloads:master.

@pippinsplugins
Copy link
Contributor

Another alternate method for this has been proposed here: #2077

@zackkatz
Copy link
Contributor Author

zackkatz commented Mar 6, 2014

Right, @pippinsplugins - I like #2077 better.

@zackkatz zackkatz closed this Mar 6, 2014
@pippinsplugins
Copy link
Contributor

Cool, so do I :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants