Custom table for discount codes - Issue/5277 #6224

pippinsplugins · 2017-12-06T04:59:22Z

Migration to custom tables for discount codes.

…greater than 0. #5722

…elper functions. #5277

…data being wiped out. #5277

spencerfinnell · 2017-12-06T13:16:21Z

🎉 @pippinsplugins there are a few method doc blocks in the meta class marking a method as private when it's defined as public.

…better column names, and better defaults. #5277

sunnyratilal · 2018-01-22T22:21:58Z

@mindctrl Only change I haven't made is prefixing the input names with edd_discount_ because it will break backwards compatibility with anyone hooking on to edd_add_discount. That also reminded me to add backwards compatibility for the old input names.

…gital-downloads into issue/5277

…turn integers. #5277

…ete_all_data. #5277

pippinsplugins · 2018-02-08T15:59:27Z

assets/js/admin-scripts.js

@@ -874,7 +874,7 @@ jQuery(document).ready(function ($) {

 		product_requirements : function() {

-			$('#products').change(function() {
+			$('#edd_products').change(function() {


ID uses an underscore here but the HTML elements class is set up with a hyphen at https://github.com/easydigitaldownloads/easy-digital-downloads/pull/6224/files#diff-2e1c495c5f0ae4bbbaddef446f7f44eeR88

pippinsplugins · 2018-02-08T16:06:03Z

includes/class-edd-db-discounts.php

+					LIMIT %d,%d;
+				", absint( $args['offset'] ), absint( $args['number'] ) ), 0 );
+
+			echo "SELECT id


This echo shouldn't be here.

pippinsplugins · 2018-02-08T16:10:35Z

includes/class-edd-discount.php

+				case 'post_mime_type' :
+				case 'comment_count' :
+				case 'filter' :
+				case 'post_type' :


I think we should return edd_discount for post_type to help ensure any custom integrations that check for the post type still function.

pippinsplugins · 2018-02-08T16:11:06Z

includes/class-edd-discount.php

@@ -271,18 +335,65 @@ public function __set( $key, $value ) {

 		// Only real properties can be saved.
 		$keys = array_keys( get_class_vars( get_called_class() ) );
+		$old_keys = array(
+			'is_single_use',


is_single_use is in the array twice.

pippinsplugins · 2018-02-08T16:23:12Z

includes/discount-functions.php

+		'_edd_discount_name',
+		'_edd_discount_code',
+		'_edd_discount_expiration',
+		'_edd_discount_start',


This is missing a few keys: _edd_discount_is_single_use, _edd_discount_is_not_global, _edd_discount_product_condition, _edd_discount_min_price, _edd_discount_max_uses`.

Same thing at line 998.

pippinsplugins added 25 commits December 4, 2017 16:17

Scaffolding for DB discounts table. #5277

62f2493

Add discount meta base

488ebd2

Begin making EDD_Discount use new table. #5277

90495c5

Move existing EDD_Discount methods to use new DB table. #5277

04fe8d6

remove unneeded properties. #5277

289ac00

Fix column definitions in SQL table creation. #5277

2defe3c

Adjust keys in table creation so creation doesn't fail. #5277

c14495d

Use exists() in edd_get_discount_by_code() instead of checking ID is …

b3e76b1

…greater than 0. #5722

Fix fatal error during insert. #5277

01349ab

Remove duplicate call to setup_discount(). #5277

3f84aaa

Make discounts list table work with new DB. #5277

12d48ef

Add get_discounts() method. #5277

ca0b1aa

Support instantiating EDD_Discount with an object of its own kind. #5277

5b17c6e

Return name when calling post_title. #5277

347b53d

Fix variable typo. #5277

00b20ed

Consider 0000-00-00 00:00:00 as a non-set expiration. #5277

5d7547c

Account for 0000-00-00 00:00:00 expiration date during setup. #5277

ac2f4af

Make update_status() use new update() method. #5277

114e3b0

Update edit discount screen to directly reference object instead of h…

3e76b1c

…elper functions. #5277

Fix discount expiration dates not showing once instantiated. #5277

e944df2

Correct start date column name. #5277

20c2938

Add comment to explain purpose of build_meta(). #5277

819f625

status not post_status. #5277

02c6b09

Display start date in list table. #5277

7793690

build_meta() cannot be called during update() as it results in other …

ec9f7a1

…data being wiped out. #5277

pippinsplugins added 4 commits December 6, 2017 09:28

Adjust DB schema based on team feedback. Better column organization, …

7476309

…better column names, and better defaults. #5277

Default product_condition to all. #5277

81bf1dd

Rework return logic for edd_store_discount(). #5277

8cfd58e

Standardize expiration and start into end_date and start_date. #5277

cb86344

Remove JavaScript from translatable text. #5277

6321505

sunnyratilal force-pushed the issue/5277 branch from 6f785d3 to 6321505 Compare January 22, 2018 22:10

Backwards compatibility for old input names. #5277

05268f8

sunnyratilal requested a review from cklosowski January 22, 2018 22:22

sunnyratilal added 16 commits January 22, 2018 22:28

Merge branch 'release/3.0' of github.com:easydigitaldownloads/easy-di…

a5f6edf

…gital-downloads into issue/5277

DocBlock. #5277

2dfd423

Ensure unit tests are compatible for PHP 7.2. #5277. See #6317

574d6ec

Switch to static test fixture. One assertion per unit test. #5277

688a02b

Use static fixtures to speed up unit tests. #5277

4ef6e82

Speed up unit tests. #5277

85a99d9

Refactor Tests_Discounts_DB to be more performant. #5277

f7baa8e

Use assertSame to ensure types match. Update counts_by_status() to re…

6555f8c

…turn integers. #5277

Merge branch 'release/3.0' into issue/5277

1c2890f

Merge release/3.0

7df80ad

Merge branch 'release/3.0' into issue/5277

958abd4

Delete old unit test case. #5277 [skip ci]

93ed6f2

Remove discounts data to ensure "vanilla" state. #5277

9ba0d7b

Introduce EDD\Tests\Factory\Discount. #5277

7db1d8b

Move to Factory. #5277

3100d8a

Remove edd_install() from running twice. Add discounts tables to _del…

a7d3aff

…ete_all_data. #5277

pippinsplugins commented Feb 8, 2018

View reviewed changes

sunnyratilal added 4 commits February 12, 2018 16:46

Remove echo. #5277

e053fde

Return edd_discount as post type for back compat. #5277

2ed5044

is_single_use should be only be in the array once #5277

287faac

Merge branch 'release/3.0' into issue/5277

3c95ef7

cklosowski mentioned this pull request Feb 13, 2018

Allow discount expiration time to be set #5766

Closed

sunnyratilal added 2 commits February 15, 2018 17:07

Add BC for all discount meta keys. #5277

a357456

Fix CSS ID selector. #5277

2501f63

sunnyratilal merged commit ab112e4 into release/3.0 Feb 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom table for discount codes - Issue/5277 #6224

Custom table for discount codes - Issue/5277 #6224

pippinsplugins commented Dec 6, 2017 •

edited

Loading

spencerfinnell commented Dec 6, 2017

sunnyratilal commented Jan 22, 2018

pippinsplugins Feb 8, 2018

pippinsplugins Feb 8, 2018

pippinsplugins Feb 8, 2018

pippinsplugins Feb 8, 2018

pippinsplugins Feb 8, 2018

pippinsplugins Feb 8, 2018

pippinsplugins Feb 8, 2018

Custom table for discount codes - Issue/5277 #6224

Custom table for discount codes - Issue/5277 #6224

Conversation

pippinsplugins commented Dec 6, 2017 • edited Loading

spencerfinnell commented Dec 6, 2017

sunnyratilal commented Jan 22, 2018

pippinsplugins Feb 8, 2018

Choose a reason for hiding this comment

pippinsplugins Feb 8, 2018

Choose a reason for hiding this comment

pippinsplugins Feb 8, 2018

Choose a reason for hiding this comment

pippinsplugins Feb 8, 2018

Choose a reason for hiding this comment

pippinsplugins Feb 8, 2018

Choose a reason for hiding this comment

pippinsplugins Feb 8, 2018

Choose a reason for hiding this comment

pippinsplugins Feb 8, 2018

Choose a reason for hiding this comment

pippinsplugins commented Dec 6, 2017 •

edited

Loading