Skip to content

Commit

Permalink
Translate still allocated return values.
Browse files Browse the repository at this point in the history 
--HG--
extra : source : b2914504481ed5299ff81bd497c91a5f24b364b7
  • Loading branch information
@Ferada
Ferada committed Apr 19, 2014
1 parent dc60e30 commit 992c608
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/functions.lisp
View file
Expand Up @@ -43,7 +43,9 @@
(defun translate-objects (syms args types rettype call-form &optional indirect)
"Helper function for FOREIGN-FUNCALL and DEFCFUN. If 'indirect is T, all arguments are represented by foreign pointers, even those that can be represented by CL objects."
(if (null args)
(expand-from-foreign call-form (parse-type rettype))
(if rettype
(expand-from-foreign call-form (parse-type rettype))
call-form)
(funcall
(if indirect
#'expand-to-foreign-dyn-indirect
Expand Down

4 comments on commit 992c608

@luismbo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this commit message. Can you (@Ferada or @easye) show me an example that is affected by this patch?

@easye
Copy link
Owner

@easye easye commented on 992c608 Aug 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete version of ae89586.

@olof is in the process of writing a commit message.

@Ferada
Copy link
Author

@Ferada Ferada commented on 992c608 Aug 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this commit should be removed.

I've uploaded https://github.com/Ferada/cffi/tree/abcl-20140920a-without-unnecessary-commits which has 992c608 removed entirely and 13e8067 squashed away into a6357e9. The commit in question, ae89586, has been subsumed somewhere (I guess one of 60e2305 to 8670336), at least all tests on cffi run through without it and drakma works as expected.

@luismbo
Copy link

@luismbo luismbo commented on 992c608 Sep 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ferada cool, can you open a pull request from that? I'll close this one.

Please sign in to comment.