Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClasOhlson.com - Broken (Easylist Cookie List / Fanboy's Annoyance List) [GDPR] #12067

Closed
THEtomaso opened this issue May 19, 2022 · 5 comments
Closed

Comments

@THEtomaso
Copy link

THEtomaso commented May 19, 2022

Affected site:

https://www.clasohlson.com/

Note:
Depending on your location, you'll get redirected to the appropriate subdirectory.
In my case, this is https://www.clasohlson.com/no/.

Issue:

Grey modal overlay / unclickable items.

Screenshot:

Not needed, as the problem is obvious.

Problem filters:

  • Easylist Cookie List
  • Fanboy's Annoyance List

Problem rules:

##.cookie-bar:not(body):not(html)
###js-cookie-notification

Possible fix:

clasohlson.com##.cookie-bar-overlay

Other problem filters:

--

System info:

  • OS/version: Windows 10 Pro (x64)
  • Browser/version: Pale Moon v29.4.6 (x64)
  • Adblock Extension/version: uBlock Origin v1.16.4.30 (XUL)
@ryanbr
Copy link
Member

ryanbr commented May 19, 2022

clasohlson.com##.cookie-bar-overlay
clasohlson.com##body,html:style(overflow: auto !important; position: initial !important;)

Does that work for you @THEtomaso

@kiboke
Copy link
Contributor

kiboke commented May 20, 2022

Thanks @THEtomaso it will be fixed today in IDCAC.

@THEtomaso
Copy link
Author

THEtomaso commented May 20, 2022

clasohlson.com##.cookie-bar-overlay
clasohlson.com##body,html:style(overflow: auto !important; position: initial !important;)

Does that work for you THEtomaso

Sure.
That first rule (which is the one that I suggested in my first post) seems to be sufficient though.
The CSS rule doesn't appear to be needed in this case (at least not when connecting from my location).

--

@kiboke:
I see that you choose to allow the cookie popup, as a solution.
Did you try to simply block the modal overlay instead, like I suggested?

@DandelionSprout
Copy link
Contributor

I sadly can't add clasohlson.com##.cookie-bar-overlay as a tempfix; it'd have to be whitelisting entries only, from my understanding of how anti-ad lists work like.

@THEtomaso
Copy link
Author

THEtomaso commented May 20, 2022

as a tempfix; it'd have to be whitelisting entries only

Well, in the case of modal overlays, blocking them doesn't really break anything, even if users aren't using additional cookie filters.
The idea behind them is simply to make coexisting popups somewhat more visible.

So, which alterative is the worst?
A missing overlay, which only results in a popup that stands out slightly less then before, on a purely cosmetical level?
..or a page that is broken, and doesn't work at all?

--

EDIT:
But of course, as an alternative temp-fix, you can whitelist the popup instead:
clasohlson.com#@#.cookie-bar:not(body):not(html)
clasohlson.com#@##js-cookie-notification

DandelionSprout added a commit to DandelionSprout/adfilt that referenced this issue May 20, 2022
@ryanbr ryanbr closed this as completed in cc74ddc May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants