Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist for Nordic Filters unbreakage tempfixes #462

Closed
DandelionSprout opened this issue Jan 23, 2022 · 22 comments
Closed

Checklist for Nordic Filters unbreakage tempfixes #462

DandelionSprout opened this issue Jan 23, 2022 · 22 comments

Comments

@DandelionSprout
Copy link
Owner

DandelionSprout commented Jan 23, 2022

As a logical outcome of THEtomaso often @-ing me to add quick or long-lasting tempfixes for Nordic sites reported to other lists, I realised I needed a checklist to know which quickfixes to add and/or remove from Nordic Filters.

Still open

Closed in a perceived-to-be-incomplete state

@THEtomaso
Copy link

THEtomaso commented Jan 24, 2022

@DandelionSprout:

Regarding the Blaklader sites..

The sites are also broken by various other filters, including EasyList Cookie List, EasyPrivacy and Fanboy's Annoyance List:
easylist/easylist#10565

..so, in addition to the fixes that you've already added, these are needed too:

blaklader.*#@#.optanon-show-settings
blaklader.*#@##onetrust-banner-sdk
blaklader.*#@##to-the-top

PS:
I really don't expect anything more that a semi-working fix from ryanbr, at best.
And when that time comes, I'm not sure if I'll bother to re-open my report (like usual), because I'm quite frankly getting tired of it!

--

EDIT:
I was wrong.
ryanbr has adopted all the necessary fixes for his filters now. 👍
Fixes for AdGuard's filters are still pending though.

@THEtomaso
Copy link

@DandelionSprout:
OK, the Blaklader.* issues have been fixed in all of the most relevant filters now, so the temp-fix can safely be removed! :)

@THEtomaso
Copy link

Add these:

skousen.no,skousen.dk#@#body,html:style(height: auto !important; overflow: auto !important)
skousen.no,skousen.dk#@##cookie-information-template-wrapper

Info:
easylist/easylist#10757 (comment)

DandelionSprout added a commit that referenced this issue Feb 27, 2022
@ryanbr
Copy link

ryanbr commented Feb 28, 2022

Why not fix it in Adguard rather than a fix it a regional list, if that's the issue

@DandelionSprout
Copy link
Owner Author

I've just rose up from bed this morning, and am therefore not certain about what AdGuard Annoyances Filter has to do with any of this.

@THEtomaso
Copy link

THEtomaso commented Feb 28, 2022

@DandelionSprout:

These open issues also affects Nordic domains:
ryanbr/fanboy-adblock#1339
ryanbr/fanboy-adblock#1372
ryanbr/fanboy-adblock#1376
ryanbr/fanboy-adblock#1405
ryanbr/fanboy-adblock#1410
ryanbr/fanboy-adblock#1468

Perhaps some of those things have changed server-side by now, thereby eliminating the need for a fix.
I'll look into it later.

@THEtomaso
Copy link

THEtomaso commented Feb 28, 2022

@DandelionSprout:

OK, I went through the reports that I linked to in my previous post, made some changes where necessary, and closed a couple of them due to site changes.
You should look into the remaining ones.

@DandelionSprout
Copy link
Owner Author

Okay, so from what I pieced together from multiple conversations spread around, is that in regards to Skousen, Fanboy seems to believe (I could be wrong on this) that there's a conflict between EasyList Cookie List and AdGuard Annoyances Filter, with the latter blocking cookieinformation.com and the former doesn't.

I'll look into the 4 reports in #462 (comment) at some point (I'm pretty booked up this evening).

@THEtomaso
Copy link

THEtomaso commented Feb 28, 2022

Judging from his post here, he seems to believe that the sites work, simply because they're browsable:
easylist/easylist#11064 (comment)

Guess he overlooked the reproduction steps, in my first post here:
easylist/easylist#10757

@THEtomaso
Copy link

THEtomaso commented Feb 28, 2022

I'll look into the 4 reports in #462 (comment) at some point

Regarding #1410:
Under "Other problem filters", I've listed a nasty rule for ekstrabladet.dk, found in Schacks Adblock Plus liste.
You should probably override that rule in your filter too, just in case some poor saps (like myself) are crazy enough to still be using that outdated filter! :)

DandelionSprout added a commit that referenced this issue Feb 28, 2022
@THEtomaso
Copy link

6623e62

ekstrabladet.dk#@#body > div[id][style] won't work, because Schack didn't formulate it that way.
It has to be ekstrabladet.dk#@#body>div[id][style] !

@THEtomaso
Copy link

Fixed:
easylist/easylist@4926fbe

For some reason, he decided not to remove the :style rule.
It doesn't break anything though.

@THEtomaso
Copy link

THEtomaso commented Mar 18, 2022

@DandelionSprout:
hvemder.no:
easylist/easylist#11357

--

EDIT:
Fixed in easylist/easylist@564fb7c

@THEtomaso
Copy link

THEtomaso commented Mar 26, 2022

@DandelionSprout:
e24.no:
easylist/easylist#11455

--

EDIT:
Fixed in easylist/easylist@ffab617

@THEtomaso
Copy link

THEtomaso commented Apr 14, 2022

bookworld.no:
easylist/easylist#11668

--

EDIT:
Fixed in easylist/easylist@a5ea95b

@THEtomaso
Copy link

Elektroskandia.no fixed in easylist/easylist@05d5f7e + easylist/easylist@584a619

@THEtomaso
Copy link

easylist/easylist#7805 fixed in easylist/easylist@544e054

@THEtomaso
Copy link

clasohlson.com:
easylist/easylist#12067

@THEtomaso
Copy link

@DandelionSprout
Copy link
Owner Author

Krystian pointed out to me at 6340cf0#commitcomment-74157847 that easylist/easylist@cc74ddc only seems to cover the uBO extension file, unless I've missed out on something.

@THEtomaso
Copy link

THEtomaso commented May 21, 2022

This seems to have been the case for a while now, with Easylist Cookie List.
Many of the fixes that ryanbr has added to it has been for uBO only, despite the fact that I've suggested simple ABP-compatible alternatives.
I really don't understand his policy in this regard, so I'm waiting for him to clarify it here:
easylist/easylist#12011 (comment)

--

EDIT:
...aaand the issue was closed, without answering my question! :(

@DandelionSprout
Copy link
Owner Author

Closing this thread in favour of #779 and/or a hypothetical future spinoff discussion of that discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants