Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A: facebook.com #5456

Closed
wants to merge 2 commits into from
Closed

A: facebook.com #5456

wants to merge 2 commits into from

Conversation

peace2000
Copy link
Contributor

@peace2000 peace2000 commented Jun 1, 2020

Adblocking for the Finnish version of Facebook.

Or should this to be done differently?

@ryanbr
Copy link
Member

ryanbr commented Jun 21, 2020

Shouldn't this be left to the Finnish list? @peace2000

@krystian3w
Copy link
Contributor

also you ate " " (space) very old ABP need this space to property use filter.

@peace2000
Copy link
Contributor Author

peace2000 commented Jun 21, 2020

@ryanbr

That's a good question. Facebook isn't a Finnish site though it does provide a Finnish UI. Personally I have thought that sites would be handled according to their nationality even though they would have multiple languages available. That has been the case with Twitter as well (rules taken from the English Easylist):

twitter.com#?#div[data-testid="UserCell"]:-abp-contains(/Promoted|Gesponsert|Promocionado|Sponsorisé|Sponsorizzato|Promowane|Promovido|Реклама|Uitgelicht|Sponsorlu|Mainostettu|推廣|推广/)

twitter.com#?#div[data-testid="placementTracking"]:-abp-has(svg + div[dir="auto"] > span:-abp-contains(/Promoted|Gesponsert|Promocionado|Sponsorisé|Sponsorizzato|Promowane|Promovido|Реклама|Uitgelicht|Sponsorlu|Mainostettu|推廣|推广|推薦|推荐/))

twitter.com#?#div[data-testid="trend"]:-abp-contains(/Promoted|Gesponsert|Promocionado|Sponsorisé|Sponsorizzato|Promowane|Promovido|Реклама|Uitgelicht|sponsorluğunda|Mainostettu|推廣|推广/)

twitter.com#?#h2[role="heading"]:-abp-contains(/Promoted Tweet|Gesponserter Tweet|推廣推文|推广推文/)

Is this a policy change?

I could of course add that rule to the Finnish list but the problem is that Eyeo still haven't added it as part of ABP's stock lists... So it would only be available for those who have added the Finnish list manually. Ubo does have it as a stock list...

@peace2000
Copy link
Contributor Author

peace2000 commented Jun 21, 2020

@krystian3w Ok, I added a space. (Though I personally think that old ABP users should rather update their versions to newer ones.)

@krystian3w
Copy link
Contributor

krystian3w commented Jun 21, 2020

Some people still like use Firefox 36 (some sites still works) on Windows XP with ABP v1.X.X.

@peace2000
Copy link
Contributor Author

Added this to the Finnish list, hopefully ABP will accept the Finnish list soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants