Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EasyList Dutch needs an update: it's very outdated #11

Merged
merged 23 commits into from
Apr 19, 2021
Merged

EasyList Dutch needs an update: it's very outdated #11

merged 23 commits into from
Apr 19, 2021

Conversation

JohnyP36
Copy link
Contributor

@JohnyP36 JohnyP36 commented Apr 7, 2021

EasyList Dutch has many rules for domains that don't exist anymore. Also sites has changed so old rules should be deleted and new ones added.

Deleting from outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
Adding new rule: should be blocked.
Deleting outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
@JohnyP36
Copy link
Contributor Author

JohnyP36 commented Apr 9, 2021

@monzta and/or @Famlam can you take a look at this pull request and merge it?
Or give me the authority to do so, if you don't have enough time?

@monzta
Copy link
Member

monzta commented Apr 13, 2021

@JohnyP36 Thanks for your contributions! As these are quite a lot of changes at once, please make sure your changes meet ABP requirements. Most importantly anti-adblock shouldn't be tackled in this list (as it is illegal in some countries) and tracking filters should go into EasyPrivacy instead.

delete "icttipsandtricks.nl##+js(acis, jQuery, ai_adb)" and "nu.nl##+js(set, is_adblocker_in_use, false)" , because does ruled not meed ABP standards.
@JohnyP36
Copy link
Contributor Author

JohnyP36 commented Apr 14, 2021

@monzta There where already anti-adblock rules in this list; I only changed them. (In the Netherlands anti-adblock isn't illegal and thus such rules could be added in EL Dutch. I live in the Netherlands)
As far as I can see now: every thing is oké and the list could be merged.

@JohnyP36
Copy link
Contributor Author

@monzta … Most importantly anti-adblock shouldn't be tackled in this list (as it is illegal in some countries) ...

To be clear as crystal: EasyList Dutch already contained anti-adblock rules. As this list is only for Dutch domains and in the Netherlands (and Belgium) anti-adblock rules aren't illegal.
So for Dutch domains anti-adblock isn't illegal + EL Dutch already contained (some) anti-adblock rules.

@monzta
Copy link
Member

monzta commented Apr 14, 2021

These are the requirements for ABP. Also old anti-adblock rules shouldn't be updated. Your PR also still contains tracking ffilters (e.g. ||smetrics.cat-care.nl^). Please remove them and add them to EasyPrivacy in case they aren't included there yet.

@JohnyP36
Copy link
Contributor Author

JohnyP36 commented Apr 15, 2021

If I remove the anti-adblock rules some parts or the complete site wouldn't work at all or not properly.

But as you wish: I will remove those rules.

@JohnyP36
Copy link
Contributor Author

@monzta I think I did all you want. @BPower0036 could check if there are no tracking filters in those lists? I think I removed them.

Nomes77 referenced this pull request in uBlockOrigin/uAssets Apr 15, 2021
@monzta monzta merged commit 50895b5 into easylist:master Apr 19, 2021
@monzta
Copy link
Member

monzta commented Apr 19, 2021

Sorry for the delay!

I think these rules belong to EasyPrivacy:

||config-prod.choice.faktor.io/*/faktor.js$script,domain=consent.talpanetwork.com
||dev.visualwebsiteoptimizer.com/j.php$script,important,domain=www.nu.nl
@@||faktor.io^$3p,domain=consent.talpanetwork.com

ABP doesn't supprt 3p and important filter options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants