Merge pull request #17 from easyops-cn/steve/fix

Steve/fix
easyops-cn · Jun 2, 2020 · 2b74337 · 2b74337
2 parents bfeabe4 + 7c6dc36
commit 2b74337
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 17 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -6,16 +6,19 @@
   ],
   "extends": [
     "eslint:recommended",
-    "plugin:@typescript-eslint/eslint-recommended",
     "plugin:@typescript-eslint/recommended",
     "plugin:react/recommended",
     "prettier",
     "prettier/@typescript-eslint"
   ],
   "env": {
+    "browser": true,
     "es6": true,
     "jest": true
   },
+  "globals": {
+    "chrome": true
+  },
   "parserOptions": {
     "ecmaVersion": 9,
     "sourceType": "module"

diff --git a/src/panel/components/EvaluationsPanel.spec.tsx b/src/panel/components/EvaluationsPanel.spec.tsx
@@ -46,7 +46,7 @@ describe("EvaluationsPanel", () => {
   it("should toggle string-wrap", () => {
     const wrapper = shallow(<EvaluationsPanel />);
     expect(wrapper.hasClass("string-wrap")).toBe(false);
-    wrapper.find("[label='String Wrap']").invoke("onChange")({
+    wrapper.find("[label='String wrap']").invoke("onChange")({
       target: {
         checked: true,
       },

diff --git a/src/panel/components/EvaluationsPanel.tsx b/src/panel/components/EvaluationsPanel.tsx
@@ -10,7 +10,6 @@ import classNames from "classnames";
 import { PanelSelector } from "./PanelSelector";
 import { useEvaluationsContext } from "../libs/EvaluationsContext";
 import { PropList, PropItem } from "./PropList";
-import { Storage } from "../libs/Storage";
 
 export function EvaluationsPanel(): React.ReactElement {
   const {
@@ -52,12 +51,8 @@ export function EvaluationsPanel(): React.ReactElement {
   const handleToggleLogs = React.useCallback(
     (event: React.FormEvent<HTMLInputElement>) => {
       savePreserveLogs((event.target as HTMLInputElement).checked);
-      // Storage.setItem(
-      //   "preserveLogs",
-      //   (event.target as HTMLInputElement).checked
-      // );
     },
-    []
+    [savePreserveLogs]
   );
 
   return (
@@ -89,7 +84,7 @@ export function EvaluationsPanel(): React.ReactElement {
           />
           <Switch
             checked={stringWrap}
-            label="String Wrap"
+            label="String wrap"
             onChange={handleToggleStringWrap}
           />
         </div>

diff --git a/src/panel/components/TransformationsPanel.spec.tsx b/src/panel/components/TransformationsPanel.spec.tsx
@@ -38,7 +38,7 @@ describe("TransformationsPanel", () => {
   it("should toggle string-wrap", () => {
     const wrapper = shallow(<TransformationsPanel />);
     expect(wrapper.hasClass("string-wrap")).toBe(false);
-    wrapper.find("[label='String Wrap']").invoke("onChange")({
+    wrapper.find("[label='String wrap']").invoke("onChange")({
       target: {
         checked: true,
       },

diff --git a/src/panel/components/TransformationsPanel.tsx b/src/panel/components/TransformationsPanel.tsx
@@ -4,7 +4,6 @@ import classNames from "classnames";
 import { PanelSelector } from "./PanelSelector";
 import { useTransformationsContext } from "../libs/TransformationsContext";
 import { PropItem } from "./PropList";
-import { Storage } from "../libs/Storage";
 
 export function TransformationsPanel(): React.ReactElement {
   const {
@@ -29,12 +28,8 @@ export function TransformationsPanel(): React.ReactElement {
   const handleToggleLogs = React.useCallback(
     (event: React.FormEvent<HTMLInputElement>) => {
       savePreserveLogs((event.target as HTMLInputElement).checked);
-      // Storage.setItem(
-      //   "preserveLogs",
-      //   (event.target as HTMLInputElement).checked
-      // );
     },
-    []
+    [savePreserveLogs]
   );
 
   return (
@@ -60,7 +55,7 @@ export function TransformationsPanel(): React.ReactElement {
           />
           <Switch
             checked={stringWrap}
-            label="String Wrap"
+            label="String wrap"
             onChange={handleToggleStringWrap}
           />
         </div>