feat: Improve no results UI when searching in context #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for easyops-cn-docusaurus-search-local ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aericson
changed the title
|
@weareoutman no hurry, just wanted to make sure you saw this. Can you take a look at this one when you have some time?We noticed that there could be some confusion when there are no results in a context and this confusion is blocking us from using the context feature. |
weareoutman
approved these changes
Mar 4, 2023
|
👍 Thanks |
Thank you for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no results on the search bar when searching within a context it can be confusing as there is no indication of the context.
This PR changes the footer to include a link to the search page without the context selected.