Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SearchBar): add shortcut (cmd/ctrl + K) support #111

Merged
merged 3 commits into from
Dec 4, 2021

Conversation

ksarlou
Copy link
Contributor

@ksarlou ksarlou commented Sep 21, 2021

This PR fixes the issue: #110 (comment)

@ksarlou ksarlou force-pushed the feature-add-shortcut-support branch from 0aa4cfb to c66851d Compare October 13, 2021 19:21
@madmath
Copy link

madmath commented Nov 8, 2021

Very nice! What's the process to get this merged?

@weareoutman
Copy link
Member

Thanks for your work and sorry for the late response. I got very little spare time to maintain this project recently. But I'll try reviewing this PR later this week.

@coveralls
Copy link

coveralls commented Nov 9, 2021

Coverage Status

Coverage decreased (-1.7%) to 76.61% when pulling 6aafb2d on ksarlou:feature-add-shortcut-support into 9093d71 on easyops-cn:master.

@ksarlou
Copy link
Contributor Author

ksarlou commented Nov 29, 2021

Hello! Thanks for your comments! Should I make any more changes?

@weareoutman
Copy link
Member

Hi @ksarlou Thanks for your contribution! And sorry again for being late. And I just made some refining based on your commit:

  • Fix dark mode colors and put the hint inside input box.
  • Fix build errors in production mode by using ExecutionEnvironment.canUseDOM.
  • Use navigator.userAgentData.platform instead of navigator.platform which is deprecated.
  • Simplify event listening.

@weareoutman weareoutman merged commit 942a815 into easyops-cn:master Dec 4, 2021
@weareoutman
Copy link
Member

Hi guys, this is just released in v0.21.0.

@ksarlou ksarlou deleted the feature-add-shortcut-support branch January 4, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants