fix(): limit ctx warnings

easyops-cn · Oct 28, 2022 · 33f2024 · 33f2024
1 parent e8a42f3
commit 33f2024
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/bricks/next-builder/src/data-providers/LintStoryboard.spec.ts b/bricks/next-builder/src/data-providers/LintStoryboard.spec.ts
@@ -41,6 +41,7 @@ describe("LintStoryboard", () => {
                       test: "<% CTX.abc %>",
                       another: "<% CTX['xyz'] %>",
                       dynamic: "<% CTX[fly] %>",
+                      more: "<% CTX.more %>",
                     },
                   },
                 ],
@@ -60,7 +61,7 @@ describe("LintStoryboard", () => {
         }),
         expect.objectContaining({
           code: "USING_CTX_IN_TPL",
-          list: ["tpl-bad: CTX.abc, CTX['xyz'], CTX[...]"],
+          list: ["tpl-bad: CTX.abc, CTX['xyz'], CTX[...], ..."],
         }),
       ],
     ],

diff --git a/bricks/next-builder/src/data-providers/chunks/doLintStoryboard.ts b/bricks/next-builder/src/data-providers/chunks/doLintStoryboard.ts
@@ -95,9 +95,13 @@ export function doLintStoryboard(storyboard: Storyboard): StoryboardError[] {
       );
 
       if (contexts.size > 0) {
-        warnedUsingCtxTemplates.push(
-          `${tpl.name}: ${[...contexts].join(", ")}`
-        );
+        const limited = [...contexts];
+        const max = 3;
+        if (limited.length > max) {
+          limited.splice(max, limited.length - max);
+          limited.push("...");
+        }
+        warnedUsingCtxTemplates.push(`${tpl.name}: ${limited.join(", ")}`);
       }
     }
   }