Ability to define custom Graph class in TypeMapper. closes #380 #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k00ni
reviewed
Apr 15, 2021
| } | ||
|
|
||
| $ancestors = class_parents($class); | ||
| if (($class != 'EasyRdf\Graph') && (empty($ancestors) || !in_array('EasyRdf\Graph', $ancestors))) { |
There was a problem hiding this comment.
I would use 0 == count($ancestors) instead of empty($ancestors) here. It improves code understanding. Never tried it with arrays but doc says:
A variable is considered empty if it does not exist or if its value equals false.
There was a problem hiding this comment.
Here I've copied the implementation of TypeMapper::setDefaultResourceClass().
Perhaps count() == 0 can be used (but not in Yoda notation, not used anywhere in the whole code).
And, even better: the whole block of conditions can be moved in a dedicated private function, to be reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added related tests.