Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters_skewness and parameters_kurtosis classes #248

Open
IndrajeetPatil opened this issue Sep 3, 2022 · 5 comments
Open

Rename parameters_skewness and parameters_kurtosis classes #248

IndrajeetPatil opened this issue Sep 3, 2022 · 5 comments

Comments

@IndrajeetPatil
Copy link
Member

IndrajeetPatil commented Sep 3, 2022

They were appropriate when these methods used to live in {parameters} package, but not now.

Should we rename them to

  • datawizard_skewness and datawizard_kurtosis,
    or
  • skewness and kurtosis?
@strengejacke
Copy link
Member

They are already kurtosis and skewness:
https://easystats.github.io/datawizard/reference/skewness.html

@IndrajeetPatil
Copy link
Member Author

I am talking about classes:

Screenshot 2022-09-03 at 20 30 12

@strengejacke
Copy link
Member

Ah, ok. If all methods are in datawizard, it should be safe to do so.

@IndrajeetPatil
Copy link
Member Author

Which of the two options do you prefer?

@strengejacke
Copy link
Member

I would prefer the one which is more likely to be unique, to avoid conflicts with other packages that have this functions too.
Hence I would prefer datawizard_skewness etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants