Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revdepcheck action doesn't work? #33

Open
etiennebacher opened this issue Mar 21, 2023 · 6 comments
Open

revdepcheck action doesn't work? #33

etiennebacher opened this issue Mar 21, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@etiennebacher
Copy link
Member

Cf easystats/datawizard#385

@IndrajeetPatil
Copy link
Member

I think easystats/performance#556 can be a good testing ground for this.

Right now, if we run revdepcheck on parameters, performance breakage should show up.

@etiennebacher
Copy link
Member Author

etiennebacher commented Mar 23, 2023

All revdep checks pass: https://github.com/easystats/parameters/actions/runs/4494885631/jobs/7907926195?pr=859

Looks like there's sth wrong here

@IndrajeetPatil
Copy link
Member

Yeah, but it's not clear to me if the tests are comparable across CRAN and GitHub versions of performance in terms of their reliance on parameters.

I am going to make an extremely breaking change (like removing an export) and then check again. If that doesn't break anything then, yes, this workflow is not working as expected.

@IndrajeetPatil
Copy link
Member

Yeah, definitely this workflow is not working. I don't understand why, though. It's the same code one runs locally.

@IndrajeetPatil IndrajeetPatil added the bug Something isn't working label May 25, 2023
@IndrajeetPatil
Copy link
Member

@easystats/maintainers Just FYI: in case you are thinking of using the revdepcheck, that workflow is currently not working. You will need to either run it locally yourself or wait for CRAN to run it after submission.

@strengejacke
Copy link
Member

Thanks, I usually also run local revdep checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants