[WIP] Python 3 Compatibility #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 4UCON_17809 - Tested FC 0.17 & FC 0.18 - BGA_packages - Tested FC 0.17 & FC 0.18 - QFN_packages - Tested FC 0.17 & FC 0.18. Fixes issue easyw#373 Note: In FreeCad 0.17 the "Report View" shows the warning "File format not supported: DFN-6-1EP_1.2x1.2mm_P0.4mm_EP0.3x0.94mm ", but it still generates the 3D model Other fixes / cleanup: - Removed ribbon.py duplicate in cadquery/FCAD_script_generator/4UCON_17809/cq_models/ribbon.py - Defined reload_lib() in cq_cad_tools.py - More functionality to check_requirements() for cleaner code *Created open_CQ_Example() - this is required to be called before close_CQ_Example(), otherwise an exception is raised *Added tests open_CQ_Example() and close_CQ_Example() into check_requirements(). *Removed references of close_CQ_Example() in the files from modules 4UCON_17809, BGA_packages and QFN_packages, since this is covered by check_requirements().
|
First commit:
|
|
@easyw Before I go too far with these changes, would you be able to check the ones I've done so far in case you want me to change the approach? In particular regarding reload_lib. I have defined this function just once in cq_cad_tools.py so that I don't need to keep re-creating the function. Thanks. |
- Altech - Battery Tested FC 0.17 & FC 0.18
- Box_Headers Tested FC 0.17 & FC 0.18
Generic python3 fixes and other manual fixes. Works fine in FC 0.17, but in FC 0.18 screen goes black.
|
Buzzer_Beeper generator module marked as done for purpose of this pull request (all python3 fixes are done). However there is another issue that needs resolving. See: #375 |
Tested in FC 0.17 and FC 0.18
…xial Tested FC 0.17 & FC 0.18
|
Thx |
|
@easyw I hadn't finished yet... i had only done 10 out of 57 modules. It was marked as [WIP] for that reason... Anyway I'll keep working on updates offline and submit a merge request when I'm finished to avoid too many merge requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Python 3 (FreeCad 0.18) compatibility.
Other fixes / cleanup carried out:
*Created open_CQ_Example() - this is required to be called before close_CQ_Example(), otherwise an exception is raised
*Added tests open_CQ_Example() and close_CQ_Example() into check_requirements().
*Removed references of close_CQ_Example() in the files from modules 4UCON_17809, BGA_packages and QFN_packages, since this is covered by check_requirements().
Current status: