Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find polyline points in custom pad #17

Closed
matthuszagh opened this issue May 21, 2019 · 2 comments
Closed

Cannot find polyline points in custom pad #17

matthuszagh opened this issue May 21, 2019 · 2 comments

Comments

@matthuszagh
Copy link

I'm getting the error shown in the issue title when trying add tracks to a loaded board (attached here):
patch_1x1x5.zip

I'm using the current Git master version of this program and Freecad 0.18.

This seems to be closely related to this issue. I imagine I could make a similar fix, however, this does seem to be a valid pcb in pcbnew so I'm reluctant to do that. Is there a reason my pcb is wrong?

On a somewhat related note, I noticed when looking through the implementation that you parse the S-expressions yourself rather than using Pcbnew's python API. Have you considered using the API?

Thanks!

@easyw
Copy link
Owner

easyw commented May 22, 2019

Hi @matthuszagh
StepUp is not covering all kicad pad models...
Particularly not full covered the Geometry ones...
I also noted that I'm not covering SMD pads on back side (B.Cu).... this last could be improved quite sooner.

Your model could be designed as in the attached FreeCAD file and in that case I can re-import the model in FreeCAD as '.kicad_mod' to check its geometry.
RF-antenna-files-v3.zip
rf-antenna

_

On a somewhat related note, I noticed when looking through the implementation that you parse the S-expressions yourself rather than using Pcbnew's python API. Have you considered using the API?

KiCAD APIs are quite unstable and depending on kicad release version... moreover they are not accessible from FC internal environment.
BTW, even with the kicad APIs, the need to convert a pad syntax to a FreeCAD geometry needs to be done.

@matthuszagh
Copy link
Author

Thanks for the response @easyw, that all makes sense. And thanks for posting the correct model!

@easyw easyw closed this as completed Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants