-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation and golint #17
Conversation
pallavJha
commented
Apr 26, 2020
•
edited
edited
- Fixes Add the code comments, documetation and golint #16
Thanks! This is going to conflict with a PR I have in progress (#15). So I'll commit to this branch after I merge that PR. I don't find it very useful to have comments that are no more explanative than the struct or function name (e.g. SelectStatement, statementKind, etc.) so I will remove those. But other than that there are some good additions here. |
I see now that golint requires all these to be documented. In that case, fine. |
Ok, after looking into things a little bit more I decided to go with just golangci-lint for now which is a little more configurable and I've used it in the past. Some of these comments could still be useful, but I'd leave that up to you. If you'd like to get the PR approved I'd say:
Thanks for the effort! |
# Conflicts: # .circleci/config.yml # Makefile # ast.go # error.go # memory.go # parser.go
Hi @eatonphil I've removed the |
Made a few changes but looks good. Thank you! |