Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasmota support broken? #693

Closed
suhajda3 opened this issue May 2, 2020 · 8 comments · Fixed by arendst/Tasmota#8412
Closed

Tasmota support broken? #693

suhajda3 opened this issue May 2, 2020 · 8 comments · Fixed by arendst/Tasmota#8412

Comments

@suhajda3
Copy link

suhajda3 commented May 2, 2020

Hello,

I have updated my Tasmota devices to v8.2.0 Elliot and homebridge-hue to v0.11.64. Since then my Tasmota devices disappeared from the Apple Home app.

Since version 8.2.0 Tasmota supports Zigbee for Hue emulation.

I have attached the two log files.

What could be the problem?

Thank you!
homebridge-hue.json.gz
homebridge.log.gz

@ebaauw
Copy link
Owner

ebaauw commented May 2, 2020

I don't have any Tasmota devices myself, so support is on a best effort basis. The Tasmota doesn't fully comply to the Hue API, so, unfortunately, occasional issues are to be expected.

[5/2/2020, 11:11:16] [Hue] Philips hue: TypeError: Cannot read property 'replace' of undefined
    at HueBridge.exposeLight (/usr/lib/node_modules/homebridge-hue/lib/HueBridge.js:684:47)

While adding support for Develco devices, v0.11.61 and later remove / characters from the manufacturername, because Eve cannot handle these. Not taking into account that the Tasmota devices fail to expose manufacturername.

ebaauw added a commit that referenced this issue May 2, 2020
Tasmota doesn't expose `manufacturername`, see #693.
@suhajda3
Copy link
Author

suhajda3 commented May 2, 2020

👍 Now it works again.

@s-hadinger Are there any plans on the Tasmota side to have better Hue compatibility? The module parameters like manufacturer name and model type are already defined in Tasmota just needed to be exposed to Hue.

@ebaauw ebaauw closed this as completed May 3, 2020
@s-hadinger
Copy link

What do you mean with "better Hue compatibility"? There is a high risk that if you don't pretend to be a Philips device, and a known Philips bulb, that device will discard the response. Actually announcing Philips devices is the best Hue compatibility we can get.

@suhajda3
Copy link
Author

suhajda3 commented May 6, 2020

I doubt that providing the correct manufacturer name would brake Hue compatibility. I also use the ESP8266HueEmulator and that exposes a manufacturer name. I had never had a problem with it with Alexa nor homebridge-hue. With Tasmota I constatly have problems with homebridge-hue because it cannot correctly identify these devices.

In a developer standpoint it's very hard to identify a device based on an empty string rather then it's real name.

Providing the manufacturer name as Tasmota and the Model number as set in Tasmota (eg.: Sonoff Basic Module) would be highly appriciated.

@s-hadinger
Copy link

Ok you convinced me. I will take a look and check that it does not break Alexa compatibility.

@s-hadinger
Copy link

@suhajda3 Confirmed, changing modelid and manufacturername does not break Alexa compatibillity, but they are not surfaced in the Alexa app either. So I'm not exactly sure why you want them changed?

What field do you expect in modelid and manufacturername? For Z2T (Zigbee) I do have a manuf/modelid. For other devices I only have the Template name which can be used for modelid, but nothing as manufacturername.

@suhajda3
Copy link
Author

suhajda3 commented May 8, 2020

I knew that Alexa doesn't use them that's why it was always working. But other apps that use Hue like homebridge-hue uses them. This ticket was created because of this. homebridge-hue also passes these values to homebridge. You can eve see them in Homebridge Config UI X.
For example my IKEA outlet that is connected to my Hue gateway and homebridge-hue connects it to my Apple Home app displays the following:
Manufacturer: IKEA of Sweden
Model: TRADFRI control outlet

I expect the manufacturername to be Tasmota and the modelid to be the template name.

Thank you!

@s-hadinger
Copy link

s-hadinger commented May 10, 2020

@suhajda3 I did the changes but unfortunately it breaks the Alexa compatibility. If the modelId is not "Extended color light", the device is not recognized as a light, and if I change the modelid it's not recognized at all.

The only thing I can safely change is the manufacturername which is not very interesting.

Edit: I can also try "productname" if that's helpful to you.

Edit2: Oh wait, it was a buffer overflow and a bad JSON. Let we rework it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants