Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TUYA Switches TS0042, TS0043, TS004F #1063

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Add support for TUYA Switches TS0042, TS0043, TS004F #1063

merged 1 commit into from
Dec 29, 2021

Conversation

nikbyte
Copy link

@nikbyte nikbyte commented Dec 25, 2021

No description provided.

Copy link
Owner

@ebaauw ebaauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the case blocks sorted by manufacturername value.

@nikbyte
Copy link
Author

nikbyte commented Dec 29, 2021

@ebaauw You mean sort these "TZ3000" blocks in different (a-z) order?
But how to be with this part?

        case '_TZ3000_i3rjdrwu':
        case '_TZ3000_dfgbtub0':

(where two conditions are the same).

@ebaauw
Copy link
Owner

ebaauw commented Dec 29, 2021

Yes, please. For the combined block, sort them on the first entry, I’d say. Not ideal, but better then duplicating the code.

I thought the deCONZ API would map these non-sensical Tuya names into something more easily consumed (like I did for the LIDL devices), but that didn’t materialise.

@nikbyte nikbyte requested a review from ebaauw December 29, 2021 20:50
@nikbyte
Copy link
Author

nikbyte commented Dec 29, 2021

@ebaauw done

@ebaauw ebaauw merged commit 96c9b34 into ebaauw:main Dec 29, 2021
Copy link
Owner

@ebaauw ebaauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants