Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unclear unref #29

Open
matthiasclasen opened this issue Nov 4, 2017 · 0 comments
Open

unclear unref #29

matthiasclasen opened this issue Nov 4, 2017 · 0 comments

Comments

@matthiasclasen
Copy link

In the middle of simplex_solver_remove_constraint, I see:

no_columns:
if (g_hash_table_lookup (solver->rows, marker) != NULL)
simplex_solver_remove_row (solver, marker, TRUE);
else
variable_unref (marker);

But I can't find a corresponding ref that the unref would match up with.

And also, a few lines further down, I see:

      if (v != marker)
        simplex_solver_remove_column (solver, v);

Even if we had a reference, should we really be dropping it before this use of marker ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthiasclasen