Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessarily transforming nested tag syntax #14

Closed
mlrawlings opened this issue Mar 2, 2018 · 1 comment
Closed

Unnecessarily transforming nested tag syntax #14

mlrawlings opened this issue Mar 2, 2018 · 1 comment
Assignees
@DylanPiercey
Labels
aspect: marko resolution: fixed type: bug
Milestone
v0.1.0

Comments

@mlrawlings
Copy link

The nested tag transformer is a bit aggressive and renames all nested tags, even if they are already using Marko's nested tag syntax.

<ebay-menu>
    <ebay-menu:item>Item</ebay-menu:item>
</ebay-menu>

becomes:

<ebay-menu>
    <ebay:menu:item>Item</ebay:menu:item>
</ebay-menu>

Honestly, probably not much of an issue once #11 and #13 are fixed, but ran into this trying to work around those issues.
@mlrawlings mlrawlings changed the title Transforming nested tag syntax Unnecessarily transforming nested tag syntax Mar 2, 2018
@ianmcburnie
Copy link
Contributor

What's the time estimate for fixing this?

@ianmcburnie ianmcburnie added this to the v0.1.0 milestone Mar 6, 2018
@DylanPiercey DylanPiercey mentioned this issue Mar 6, 2018
Merged
yomed pushed a commit that referenced this issue Mar 6, 2018
@DylanPiercey @yomed
Improve tag transformer to support dash and colon #14 (#24)
94ce4ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DylanPiercey DylanPiercey

Labels
aspect: marko resolution: fixed type: bug
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
4 participants
@ianmcburnie @jammur @mlrawlings @DylanPiercey