Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: Pill #8

Closed
ianmcburnie opened this issue Mar 2, 2018 · 4 comments
Closed

New Component: Pill #8

ianmcburnie opened this issue Mar 2, 2018 · 4 comments

Comments

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Mar 2, 2018

Design doc:
https://ebay.invisionapp.com/share/CWN9X1JF6MA#/screens/293357159

@msendlakowski
Copy link
Contributor

msendlakowski commented Sep 15, 2018

@seangates @yomed
Based on our skin discussion we need a JS solution for line-clamp. This is something I created a while ago.

[redacted]

Do you have any other solutions or should I modify this for the component?

Also, whatever solution we come up with, I'm thinking to add it as a common utility. What do you think?

@seangates
Copy link
Contributor

👍 for common utility.

@ianmcburnie ianmcburnie removed this from To do in v1.1.0 Oct 12, 2018
@ianmcburnie ianmcburnie removed this from the v1.1.0 milestone Oct 12, 2018
@ianmcburnie ianmcburnie added this to To do in v2.0.0 via automation Oct 29, 2018
@ianmcburnie ianmcburnie added this to the v2.0.0 milestone Oct 29, 2018
@ianmcburnie ianmcburnie moved this from To do to In progress in v2.0.0 Oct 29, 2018
@ianmcburnie
Copy link
Contributor Author

I guess adding a pill boolean to ebay-button is the simplest way to go, but if there are going to be some button attributes not suitable or relevant to the pill, I wonder if it's worth creating an ebay-pill which acts as a simplified facade to ebay-button?

@seangates
Copy link
Contributor

Well, a lot of the attributes will be handled with state inside the ebay-pill component (e.g. checked state) so we wouldn't want to expose those the same was as the ebay-button. It's a button ... but more of a button type with limited button options.

So, I'm 100% in line with your thinking.

@ianmcburnie ianmcburnie moved this from In progress to Pull request in v2.0.0 Nov 13, 2018
seangates added a commit that referenced this issue Nov 29, 2018
v2.0.0 automation moved this from Pull request to Done Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2.0.0
  
Done
Development

No branches or pull requests

5 participants