Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebay-icon: remove all duplicate classes #2339

Closed
6 tasks
agliga opened this issue May 22, 2024 · 0 comments · Fixed by #2346
Closed
6 tasks

ebay-icon: remove all duplicate classes #2339

agliga opened this issue May 22, 2024 · 0 comments · Fixed by #2346
Assignees
@agliga
Labels
type: feature
Milestone
18.0.0

Comments

@agliga
Copy link
Contributor

agliga commented May 22, 2024

Description

We should remove all classes from ebay-icon and use generic icon-20 for width/height 20px.
This will reduce the file size as well.

Screenshots

No response

Figma link

No response

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@agliga agliga added this to the 18.0.0 milestone May 22, 2024
@agliga agliga self-assigned this May 22, 2024
@agliga agliga mentioned this issue May 30, 2024
Merged
9 tasks
@agliga agliga closed this as completed Jun 24, 2024
@agliga agliga mentioned this issue Jun 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agliga agliga

Labels
type: feature
Projects
eBayUI
Status: Done
Milestone
18.0.0
Development

Successfully merging a pull request may close this issue.

feat(icon): removed all duplicate icon classes eBay/skin
1 participant
@agliga