-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsv-summarize: doesn't support windows line-ending #96
Comments
Thanks for the report and for trying the tools. The only tool explicitly supporting Windows line-endings on Linux is What's going on is that the tools are using D standard library functions for reading lines, these functions assume unix line endings on unix platforms. If the file has Windows line ending (a In the case of As an example:
I'm not inclined to add support for Windows line endings on Unix platforms. The However, something is going wrong with the error message formatting, and the error message should identify a Windows line ending as a likely problem. The documentation for the tools should also discuss line endings. I'll have to look into both of these. Regarding |
The badly formatted error message is due to the |
Thanks for your explanation and the great tools. As you said, I used |
Current plan: On Unix builds, check for Windows/DOS line endings when processing the first line of a file. That should handle most cases prior to ever hitting the error message. Regarding the poor error message format: There's an open D bug for it: https://issues.dlang.org/show_bug.cgi?id=17708 |
Addressed by PR #103, merged to master. Will be included in the next release. |
Included in release v.1.1.16. |
When aggregating the last column, the prebuilt binary for linux (v1.1.15) returns the following error:
I've used tsv-append, tsv-uniq and tsv-select, and each works just fine. After updating line-endings to unix, tsv-summarize works.
The text was updated successfully, but these errors were encountered: