Changes for 2023.12.8 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make media.Track.get() take album and metadata arguments to that media.Album.get_tracks() can directly call media.Track.get() If only 1 URL is presented by the manifest, GET it with HTTP range requests requesting.py: add three functions that generate range request headers for a given URL
Add new method: media.Track.save_artist_bio() Add new class: models.ArtistsBioResponseJSON Add new function: requesting.request_artist_bio Remove whitespace in utils.py
* First commit to do with downloading videos * Update pyproject.toml to 2023.12.4 * Comprehensive update: hls.py: Fix RequestsClient.download signature, clarify playlister() variable main.py: add logic branches for TidalVideo type passed from CLI media.py: add the request_* functions from requesting.py to do with videos; flesh out media.Video methods that get called in media.Video.get() models.py: add class TidalVideo, add TidalVideo logic to match_tidal_url() requesting.py: import VideosEndpointStreamResponseJSON and create request_video_contributors() function utils.py: add temporary_file() facsimile of tempfile.NamedTemporaryFile from upstream
* Implement playlist feature completely: Create new file, playlists.py Changes to almost every other file in order to support playlist (audio or video or both) retrieval * Format with Black
Change logger errors to logger warnings in login.load_token_from_disk() Add missing 'director' key in media.TAG_MAPPING Protect None-return of media.Track.get_stream() Bare except of media.Track.get_lyrics() Replace colon in track and video files' names (issue #13) Comment out unused fields in several models classes Add try/except for HTTP code 401 in requesting.py
ebb-earl-co
added
bug
|
This fixes issue #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly add more logic in
playlists.Playlist.flatten_playlist_dir(). Also, change file names to replace ":" with "- "