Fix: gradle plugin #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump gradle plugin version
|
It looks good except for that rename of the io.ebean.properties file ... I think that file name needs to match the plugin id which changed from "ebean" to "io.ebean" ... but yes I'll merge it in shortly and check. Cheers, Rob. |
|
if the file is named io.ebean.properties gradle can not find the plugin using apply plugin: 'ebean'. Maybe one must use apply plugin: 'io.ebean' than. I did not check that. But if we want to use 'ebean' as plugin name the file must be ebean.properties |
|
Yes, we need to use:
apply plugin: 'io.ebean'
We had to change the name to 'io.ebean' to deploy to the Gradle plugins
repo. That is how the plugin is deployed now to both to the gradle repo and
maven central.
So note that if we are not using 'io.ebean' ... we are not using the latest
released plugin.
…On 21 February 2018 at 11:05, Victor Nike ***@***.***> wrote:
if the file is named io.ebean.properties gradle can not find the plugin
using apply plugin: 'ebean'. Maybe one must use apply plugin: 'io.ebean'
than. I did not check that. But if we want to use 'ebean' as plugin name
the file must be ebean.properties
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMwTdTcS3_cEeYEUpJ9Xsv0bVdeI1Deks5tW0GXgaJpZM4SK_QX>
.
|
|
Also, docs are at: http://ebean-orm.github.io/docs/tooling/gradle
... so we need to review those.
…On 21 February 2018 at 11:31, Rob Bygrave ***@***.***> wrote:
Yes, we need to use:
apply plugin: 'io.ebean'
We had to change the name to 'io.ebean' to deploy to the Gradle plugins
repo. That is how the plugin is deployed now to both to the gradle repo and
maven central.
So note that if we are not using 'io.ebean' ... we are not using the
latest released plugin.
On 21 February 2018 at 11:05, Victor Nike ***@***.***>
wrote:
> if the file is named io.ebean.properties gradle can not find the plugin
> using apply plugin: 'ebean'. Maybe one must use apply plugin: 'io.ebean'
> than. I did not check that. But if we want to use 'ebean' as plugin name
> the file must be ebean.properties
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#16 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAMwTdTcS3_cEeYEUpJ9Xsv0bVdeI1Deks5tW0GXgaJpZM4SK_QX>
> .
>
|
|
In that case maybe only README should be merged along with changes to use io.ebean |
|
Updated the README - should be all good now, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: > Plugin with id 'ebean' not found.
because ebean.properties was renamed to io.ebean.properties ebean plugin can not be started using apply plugin: ebean
I alse updated README.md - using latest eben versions.
Please review and merge.