[ModifyAware] Noticed that this boolean parameter was ignored. #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some quick analysis, implemented that way it probably should be used. Of course, this could have been on purpose, please advise.
|
Thanks. Yes, I think the use in ScalarTypeArraySet needs to pass true so I'll look to change that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some quick analysis, implemented the way it probably should be used.
Of course, this could have been on purpose, please advise. There are 2 places in the production code where this is used, once with true, once with false.
Here: https://github.com/ebean-orm/ebean/blob/master/src/main/java/io/ebeaninternal/server/type/ScalarTypeArraySet.java#L126
And here: https://github.com/ebean-orm/ebean/blob/master/src/main/java/io/ebeaninternal/server/type/ScalarTypeJsonSet.java#L77
And I personally don't have a way of testing the influence of this change. It just seemed like the parameter was ignored.