Fix / support JSON marshalling of BeanChange + add changeLogAsync option to ServerConfig #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changeLogAsync defaults to false ... so I'll ponder if that is the correct / desired default. The plugin I want / plan to have pushes the change logs into elasticsearch. |
rbygrave
changed the title
|
I think you're right, changeLogAsync should be initialized with true as default value. |
rbygrave
added a commit
that referenced
this pull request
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deserialization of the BeanChange and adds the ability to write changelog synchronious - and the test can detect failures