Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed test to detect issue #1717 #1721

Merged
merged 1 commit into from May 20, 2019
Merged

changed test to detect issue #1717 #1721

merged 1 commit into from May 20, 2019

Conversation

rPraml
Copy link
Contributor

@rPraml rPraml commented May 20, 2019

This is a followup to #1717, hope it is clear now, that there is a problem
(sorry, it was my mistake I ported the test wrong from our application)

@rPraml
Copy link
Contributor Author

rPraml commented May 20, 2019

Yeah, the test is failing now ;)
@rbygrave The reverted commit would fix the problem, maybe you can take a look if you have a better solution, maybe CacheChangeSet.addClearQuery can/should also touch the table

@rbygrave
Copy link
Member

maybe CacheChangeSet.addClearQuery can/should also touch the table

Yes, I was thinking the same thing, put it internal to addClearQuery().

@rbygrave rbygrave added the bug label May 20, 2019
@rbygrave rbygrave added this to the 11.39.1 milestone May 20, 2019
@rbygrave rbygrave merged commit 0762eaf into ebean-orm:master May 20, 2019
rbygrave added a commit that referenced this pull request May 20, 2019
@rbygrave
#1717 #1721 - Fix for table touch with query cache clear
3829613
@rPraml rPraml deleted the changed-testcase branch November 22, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rPraml rPraml

Labels
bug
Projects
None yet
Milestone
11.39.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rPraml @rbygrave